Skip to content

update xx to 1.9.0#357

Merged
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:update-xx
Jan 30, 2026
Merged

update xx to 1.9.0#357
crazy-max merged 1 commit intodocker:mainfrom
crazy-max:update-xx

Conversation

@crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 29, 2026

No description provided.

@crazy-max crazy-max requested review from a team as code owners January 29, 2026 09:11
@crazy-max crazy-max requested review from glours and ndeloof and removed request for a team January 29, 2026 09:11
@thaJeztah
Copy link
Member

thaJeztah commented Jan 29, 2026

cagent broken again (or was it still broken?) cc @rumpl @krissetto #350 (comment)

> [linux/amd64->darwin/amd64 builder-static 7/7] RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build     --mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver     --mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc     --mount=type=bind,from=src,source=/src,target=/usr/local/src/cagent     --mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw     --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk     OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/cagent pkg-static-build:
72.97 typedef NS_ENUM(NSInteger, NSQualityOfService) {
72.97                 ^
72.97 /xx-sdk/MacOSX15.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:660:17: error: unknown type name 'NSInteger'
72.97 /xx-sdk/MacOSX15.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:668:14: error: unknown type name 'NSInteger'
72.97 static const NSInteger NSNotFound = NSIntegerMax;
72.97              ^
72.97 /xx-sdk/MacOSX15.5.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSObjCRuntime.h:668:37: error: use of undeclared identifier 'NSIntegerMax'
72.97 static const NSInteger NSNotFound = NSIntegerMax;
72.97                                     ^
72.97 45 errors generated.
------
Dockerfile:195
--------------------
 194 |     ARG TARGETPLATFORM
 195 | >>> RUN --mount=type=bind,source=scripts/pkg-static-build.sh,target=/usr/local/bin/pkg-static-build \
 196 | >>>     --mount=type=bind,from=scripts,source=gen-ver.sh,target=/usr/local/bin/gen-ver \
 197 | >>>     --mount=type=bind,from=scripts,source=fix-cc.sh,target=/usr/local/bin/fix-cc \
 198 | >>>     --mount=type=bind,from=src,source=/src,target=/usr/local/src/cagent \
 199 | >>>     --mount=type=bind,from=gocross,source=/usr/local/go,target=/usr/local/go,rw \
 200 | >>>     --mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \
 201 | >>>     OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/cagent pkg-static-build
 202 |     
--------------------
ERROR: failed to solve: process "/bin/sh -c OUTDIR=/out BUILDDIR=/build SRCDIR=/usr/local/src/cagent pkg-static-build" did not complete successfully: exit code: 1

@rumpl rumpl mentioned this pull request Jan 29, 2026
Closed
@rumpl
Copy link
Member

rumpl commented Jan 29, 2026

@thaJeztah I created an issue for us to take a look and fix this, docker/cagent#1529

We recently added a feature where you can speak to cagent instead of typing so I guess it needs some Darwin SDKs

@crazy-max
Copy link
Member Author

crazy-max commented Jan 29, 2026 •
edited
Loading

so I guess it needs some Darwin SDKs

We load the sdk on static builds:

packaging/pkg/cagent/Dockerfile

Line 200 in 62ab921

--mount=type=bind,from=osxcross,src=/osxsdk,target=/xx-sdk \

And I see the image is the same as upstream:

But I don't see any darwin builds upstream in cagent pipeline, it only builds for default platform of the runner (linux/amd64) atm: https://github.com/docker/cagent/blob/9eb172022ca71a0702cf01d659d49001d12fbb6b/.github/workflows/ci.yml#L96

@crazy-max crazy-max mentioned this pull request Jan 30, 2026
Merged
@crazy-max
update xx to 1.9.0
36279dc 
Signed-off-by: CrazyMax <[email protected]>
@crazy-max crazy-max merged commit 35f3499 into docker:main Jan 30, 2026
528 checks passed
@crazy-max crazy-max deleted the update-xx branch January 30, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@glours glours glours approved these changes

@doringeman doringeman doringeman approved these changes

@ndeloof ndeloof Awaiting requested review from ndeloof ndeloof is a code owner automatically assigned from docker/compose-maintainers

Assignees

No one assigned

Labels

area/pkg/buildx area/pkg/cagent area/pkg/compose area/pkg/containerd area/pkg/credential-helpers area/pkg/docker-cli area/pkg/docker-engine area/pkg/model

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crazy-max @thaJeztah @rumpl @glours @doringeman